fix: add shorthand record field completions #20831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
A4-Tacks
force-pushed
the
record-expr-shorthand
branch
from
9469076 to
6c29055
Compare
ChayimFriedman2
approved these changes
Oct 22, 2025
| let field_name = field.name(ctx.db); | ||
|
|
||
| if let Some(local) = ctx.locals.get(&field_name) | ||
| && local.ty(ctx.db) == field.ty(ctx.db).to_type(ctx.db) |
There was a problem hiding this comment.
A bit better to use could_unify_deeply(), I believe, although I won't hold strong on this.
There was a problem hiding this comment.
It should be Type::could_unify_with_deeply, right
Example
---
```rust
struct Foo { bar: bool, n: i32 }
fn baz() {
let bar = true;
let foo: Foo = Fo$0;
}
```
**Before this PR**:
```rust
struct Foo { bar: bool, n: i32 }
fn baz() {
let bar = true;
let foo: Foo = Foo { bar: ${1:()}, n: ${2:()} }$0;
}
```
**After this PR**:
```rust
struct Foo { bar: bool, n: i32 }
fn baz() {
let bar = true;
let foo: Foo = Foo { bar$1, n: ${2:()} }$0;
}
```
A4-Tacks
force-pushed
the
record-expr-shorthand
branch
from
6c29055 to
9a9f011
Compare
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
mendelsshop
pushed a commit
to mendelsshop/rust-analyzer
that referenced
this pull request
Oct 27, 2025
Add shorthand field completion for record-expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #20830
Example
Before this PR:
After this PR: